From 75f7c36bc7207fb6937a40eb500ad5d7f2fd6d20 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sun, 31 Oct 2021 18:44:17 +1100 Subject: [PATCH] AP_Logger: avoid all opens of log files in main thread this fixes a problem with sdcards where file open is very slow. It can trigger a watchdog if it is slow enough. Peter and I hit this issue on a pixracer today with a new sd card --- libraries/AP_Logger/AP_Logger_File.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/libraries/AP_Logger/AP_Logger_File.cpp b/libraries/AP_Logger/AP_Logger_File.cpp index 989a0c96af..89613d6ed5 100644 --- a/libraries/AP_Logger/AP_Logger_File.cpp +++ b/libraries/AP_Logger/AP_Logger_File.cpp @@ -130,7 +130,8 @@ void AP_Logger_File::periodic_1Hz() erase.was_logging) { // restart logging after an erase if needed erase.was_logging = false; - start_new_log(); + // setup to open the log in the backend thread + start_new_log_pending = true; } if (_initialised && @@ -138,15 +139,8 @@ void AP_Logger_File::periodic_1Hz() _write_fd == -1 && _read_fd == -1 && logging_enabled() && !recent_open_error()) { - // retry logging open. This allows for booting with - // LOG_DISARMED=1 with a bad microSD or no microSD. Once a - // card is inserted then logging starts - // this also allows for logging to start after forced arming - if (!hal.util->get_soft_armed()) { - start_new_log(); - } else { - start_new_log_pending = true; - } + // setup to open the log in the backend thread + start_new_log_pending = true; } if (!io_thread_alive()) {