From 588e2e0745dc524f94931443b66f0fe550cdb7e0 Mon Sep 17 00:00:00 2001
From: Peter Barker <pbarker@barker.dropbear.id.au>
Date: Fri, 4 Feb 2022 14:33:38 +1100
Subject: [PATCH] Rover: remove logging of STRT message

SType is always 1 - and we're just about to log the entire
mission so CTOT is pointless
---
 Rover/Log.cpp   | 29 -----------------------------
 Rover/Rover.h   |  1 -
 Rover/defines.h |  3 ---
 3 files changed, 33 deletions(-)

diff --git a/Rover/Log.cpp b/Rover/Log.cpp
index 9aaa503c46..6f40ceae0b 100644
--- a/Rover/Log.cpp
+++ b/Rover/Log.cpp
@@ -183,24 +183,6 @@ struct PACKED log_Steering {
     float turn_rate;
 };
 
-struct PACKED log_Startup {
-    LOG_PACKET_HEADER;
-    uint64_t time_us;
-    uint8_t startup_type;
-    uint16_t command_total;
-};
-
-void Rover::Log_Write_Startup(uint8_t type)
-{
-    struct log_Startup pkt = {
-        LOG_PACKET_HEADER_INIT(LOG_STARTUP_MSG),
-        time_us         : AP_HAL::micros64(),
-        startup_type    : type,
-        command_total   : mode_auto.mission.num_commands()
-    };
-    logger.WriteBlock(&pkt, sizeof(pkt));
-}
-
 // Write a steering packet
 void Rover::Log_Write_Steering()
 {
@@ -259,7 +241,6 @@ void Rover::Log_Write_RC(void)
 void Rover::Log_Write_Vehicle_Startup_Messages()
 {
     // only 200(?) bytes are guaranteed by AP_Logger
-    Log_Write_Startup(TYPE_GROUNDSTART_MSG);
     logger.Write_Mode(control_mode->mode_number(), control_mode_reason);
     ahrs.Log_Write_Home_And_Origin();
     gps.Write_AP_Logger_Log_Startup_messages();
@@ -272,15 +253,6 @@ void Rover::Log_Write_Vehicle_Startup_Messages()
 const LogStructure Rover::log_structure[] = {
     LOG_COMMON_STRUCTURES,
 
-// @LoggerMessage: STRT
-// @Description: Startup messages
-// @Field: TimeUS: Time since system startup
-// @Field: SType: Type of startup
-// @Field: CTot: Total number of commands in the mission
-
-    { LOG_STARTUP_MSG, sizeof(log_Startup),
-      "STRT", "QBH",        "TimeUS,SType,CTot", "s--", "F--" },
-
 // @LoggerMessage: THR
 // @Description: Throttle related messages
 // @Field: TimeUS: Time since system startup
@@ -347,7 +319,6 @@ void Rover::Log_Write_Depth() {}
 void Rover::Log_Write_GuidedTarget(uint8_t target_type, const Vector3f& pos_target, const Vector3f& vel_target) {}
 void Rover::Log_Write_Nav_Tuning() {}
 void Rover::Log_Write_Sail() {}
-void Rover::Log_Write_Startup(uint8_t type) {}
 void Rover::Log_Write_Throttle() {}
 void Rover::Log_Write_RC(void) {}
 void Rover::Log_Write_Steering() {}
diff --git a/Rover/Rover.h b/Rover/Rover.h
index 3436380c37..691bdfcaa9 100644
--- a/Rover/Rover.h
+++ b/Rover/Rover.h
@@ -327,7 +327,6 @@ private:
     void Log_Write_GuidedTarget(uint8_t target_type, const Vector3f& pos_target, const Vector3f& vel_target);
     void Log_Write_Nav_Tuning();
     void Log_Write_Sail();
-    void Log_Write_Startup(uint8_t type);
     void Log_Write_Steering();
     void Log_Write_Throttle();
     void Log_Write_RC(void);
diff --git a/Rover/defines.h b/Rover/defines.h
index 1546f865de..c3982e2246 100644
--- a/Rover/defines.h
+++ b/Rover/defines.h
@@ -21,13 +21,10 @@
 enum LoggingParameters {
     LOG_THR_MSG,
     LOG_NTUN_MSG,
-    LOG_STARTUP_MSG,
     LOG_STEERING_MSG,
     LOG_GUIDEDTARGET_MSG,
 };
 
-#define TYPE_GROUNDSTART_MSG    0x01
-
 #define MASK_LOG_ATTITUDE_FAST  (1<<0)
 #define MASK_LOG_ATTITUDE_MED   (1<<1)
 #define MASK_LOG_GPS            (1<<2)